Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TraceState to adhere to specs #1487

Closed
lzchen opened this issue Dec 16, 2020 · 2 comments · Fixed by #1502
Closed

Fix TraceState to adhere to specs #1487

lzchen opened this issue Dec 16, 2020 · 2 comments · Fixed by #1502
Assignees
@srikanthccv
Labels
api Affects the API package. good first issue Good first issue help wanted tracing

Comments

@lzchen
Copy link
Contributor

lzchen commented Dec 16, 2020

From the specs:

  1. All mutating operations MUST return a new TraceState with the modifications applied
  2. TraceState MUST at all times be valid according to rules specified in W3C Trace Context specs
  3. Error handling -> must not return null or throw an exception (should log)
@lzchen lzchen added good first issue Good first issue api Affects the API package. tracing help wanted 1.0.0rc1 labels Dec 16, 2020
@srikanthccv
Copy link
Member

srikanthccv commented Dec 18, 2020 •
edited
Loading

@codeboten as discussed in SIG meeting, assign this to me. I will start work on this weekend.

@codeboten
Copy link
Contributor

Done, thanks @lonewolf3739!

@srikanthccv srikanthccv mentioned this issue Dec 24, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanthccv srikanthccv

Labels
api Affects the API package. good first issue Good first issue help wanted tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TraceState to adhere to specs srikanthccv/opentelemetry-python
3 participants
@codeboten @lzchen @srikanthccv