Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParentBased sampler should have delegate samplers for different parent span states #1397

Closed
mariojonke opened this issue Nov 19, 2020 · 0 comments · Fixed by #1440
Closed
Assignees
Labels
release:required-for-ga To be resolved before GA release sdk Affects the SDK package. tracing

Comments

@mariojonke
Copy link
Contributor

Spec mentions that for the ParentBased sampler there should be a delegate sampler for each of the following states of a parent span:

  • local sampled parent span
  • local not sampled parent span
  • remote sampled parent span
  • remote not sampled parent span
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:required-for-ga To be resolved before GA release sdk Affects the SDK package. tracing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants