Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of ExportRecord and ExportRecordSet #1345

Closed
ocelotl opened this issue Nov 4, 2020 · 6 comments
Closed

Lack of ExportRecord and ExportRecordSet #1345

ocelotl opened this issue Nov 4, 2020 · 6 comments
Assignees
@shovnik
Labels
1.10.0rc1 release candidate 1 for metrics GA bug Something isn't working metrics release:required-for-ga To be resolved before GA release sdk Affects the SDK package.

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Nov 4, 2020

The specification defines ExportRecord and ExportRecordSet. They are not implemented.
@ocelotl ocelotl added bug Something isn't working sdk Affects the SDK package. metrics labels Nov 4, 2020
@shovnik
Copy link
Contributor

shovnik commented Nov 9, 2020

I will be taking on this issue as it is related to the issue #1307 I created.

@shovnik shovnik mentioned this issue Nov 9, 2020
Merged
3 tasks
@codeboten codeboten added release:required-for-ga To be resolved before GA release 1.10.0rc1 release candidate 1 for metrics GA labels Nov 26, 2020
@shovnik
Copy link
Contributor

shovnik commented Dec 11, 2020

I believe this issue can be resolved.

@ocelotl
Copy link
Contributor Author

ocelotl commented Dec 11, 2020

@shovnik I see ExportRecordSet not being present. Is ExportRecord enough?

@shovnik
Copy link
Contributor

shovnik commented Dec 11, 2020

Do we need to create a class called ExportRecordSet that only contains an array of ExportRecords to comply? I thought returning a list of ExportRecords would be sufficient in our case.

@lzchen
Copy link
Contributor

lzchen commented Dec 14, 2020

IMO the specs shouldn't be telling us how to implement a "set of export records". I would bring up this issue to the specs.

@ocelotl
Copy link
Contributor Author

ocelotl commented Dec 16, 2020

IMO the specs shouldn't be telling us how to implement a "set of export records". I would bring up this issue to the specs.

I agree, I was just checking 🙂 A comment that mentions this would be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shovnik shovnik

Labels
1.10.0rc1 release candidate 1 for metrics GA bug Something isn't working metrics release:required-for-ga To be resolved before GA release sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@codeboten @ocelotl @lzchen @shovnik