Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of Accumulation #1343

Closed
ocelotl opened this issue Nov 3, 2020 · 3 comments
Closed

Lack of Accumulation #1343

ocelotl opened this issue Nov 3, 2020 · 3 comments
Assignees
Labels
bug Something isn't working metrics sdk Affects the SDK package.

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Nov 3, 2020

The specification defines an Accumulation

Just for the record, the Go implementation has an Accumulation. This implementation does not.

@ocelotl ocelotl added bug Something isn't working sdk Affects the SDK package. metrics labels Nov 3, 2020
@AzfaarQureshi
Copy link
Contributor

Hi! I'd be willing to pick this up 😄 From my understanding here, this is also a renaming change from Record to Accumulation, right?

@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 13, 2020

I have corrected the issue statement to reflect the fact that we (as the rest of the implementations) follow the specification. We sometimes draw guidance from other existing implementations.

@AzfaarQureshi
Copy link
Contributor

should this issue be closed now that #1373 is merged?

@lzchen lzchen closed this as completed Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metrics sdk Affects the SDK package.
Projects
None yet
Development

No branches or pull requests

3 participants