Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of Accumulator #1342

Closed
ocelotl opened this issue Nov 3, 2020 · 3 comments
Closed

Lack of Accumulator #1342

ocelotl opened this issue Nov 3, 2020 · 3 comments
Assignees
@AzfaarQureshi
Labels
bug Something isn't working metrics sdk Affects the SDK package.

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Nov 3, 2020 •
edited
Loading

The specification defines an Accumulator

Just for the record, the Go implementation has an Accumulator. This implementation does not.
@ocelotl ocelotl added bug Something isn't working sdk Affects the SDK package. metrics labels Nov 3, 2020
@AzfaarQureshi
Copy link
Contributor

Hey! I'd be willing to pick this up. From my understanding here, this is just requires renaming the meter class to Accumulator right?

This was referenced Nov 9, 2020
Closed
Closed
Merged
Merged
@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 13, 2020

I have corrected the issue statement to reflect the fact that we (as the rest of the implementations) follow the specification. We sometimes draw guidance from other existing implementations. Also assigned @AzfaarQureshi who has work already done for this issue.

@AzfaarQureshi
Copy link
Contributor

is this issue okay to be closed now that #1372 is merged?

@lzchen lzchen closed this as completed Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AzfaarQureshi AzfaarQureshi

Labels
bug Something isn't working metrics sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ocelotl @lzchen @AzfaarQureshi