Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time_unix_nano and start_time_unix_nano may be wrongly set #1340

Closed
ocelotl opened this issue Nov 3, 2020 · 2 comments
Closed

time_unix_nano and start_time_unix_nano may be wrongly set #1340

ocelotl opened this issue Nov 3, 2020 · 2 comments
Labels
1.10.0rc1 release candidate 1 for metrics GA backlog bug Something isn't working metrics release:required-for-ga To be resolved before GA release sdk Affects the SDK package.

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Nov 3, 2020 •
edited
Loading

This issue tracks the discussion between myself, @ocelotl, @lzchen and @codeboten regarding how these timestamps are being set.

Just for the record, the Go seems to follow a considerably different path to define these values, beginning with the fact that its implementation supports current, delta and cumulative Aggregators in state values.
@ocelotl ocelotl added bug Something isn't working sdk Affects the SDK package. metrics labels Nov 3, 2020
@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 13, 2020 •
edited
Loading

I have corrected the issue statement make it more clear an specific and to reflect the fact that we (as the rest of the implementations) follow the specification. We sometimes draw guidance from other existing implementations.

@ocelotl ocelotl changed the title Lack of support for current, delta and cumulative Aggregators in state values time_unix_nano and start_time_unix_nano may be wrongly set Nov 13, 2020
@ocelotl ocelotl mentioned this issue Nov 13, 2020
Closed
@codeboten codeboten added 1.10.0rc1 release candidate 1 for metrics GA release:required-for-ga To be resolved before GA release labels Nov 26, 2020
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.10.0rc1 release candidate 1 for metrics GA backlog bug Something isn't working metrics release:required-for-ga To be resolved before GA release sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeboten @ocelotl