Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Jaeger propagator #1103

Closed
codeboten opened this issue Sep 14, 2020 · 9 comments · Fixed by #1219
Closed

Add support for Jaeger propagator #1103

codeboten opened this issue Sep 14, 2020 · 9 comments · Fixed by #1219
Assignees
Labels
good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release

Comments

@codeboten
Copy link
Contributor

As per spec, we must provide support for the Jaeger propagation format: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/context/api-propagators.md#propagators-distribution

@codeboten codeboten added good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release labels Sep 14, 2020
@Rashmi-K-A
Copy link
Contributor

Hey @codeboten, could you elaborate on this a bit? Was wondering if I could pick this up!

@codeboten
Copy link
Contributor Author

Hi @Rashmi-K-A, this issue is to add a new propagator to handle the Jaeger format specified here. Here's an example of an existing propagator that's already implemented: https://github.com/open-telemetry/opentelemetry-python/blob/master/opentelemetry-sdk/src/opentelemetry/sdk/trace/propagation/b3_format.py

@codeboten
Copy link
Contributor Author

Let me know if you'd like to take this on and I can assign it to you, thanks!

@Rashmi-K-A
Copy link
Contributor

@codeboten yep, I'll take this one!

@codeboten
Copy link
Contributor Author

Assigned, thanks!

@Rashmi-K-A
Copy link
Contributor

Hi, @codeboten, the implementation of the extractor function for Jaeger format requires a keys method implemented to extract keys with the prefix 'uberctx-'. I took a look at the spec discussion here and I don't see any other way out. Advice on how to proceed please!

@codeboten
Copy link
Contributor Author

Hey @Rashmi-K-A, looks like it's probably worth addressing this issue first then: #1084, did you want to tackle that one?

@Rashmi-K-A
Copy link
Contributor

Someone picked it up, I'll wait for that issue to be closed before raising a PR!

@codeboten
Copy link
Contributor Author

Wow that was quick, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants