-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Jaeger propagator #1103
Comments
Hey @codeboten, could you elaborate on this a bit? Was wondering if I could pick this up! |
Hi @Rashmi-K-A, this issue is to add a new propagator to handle the Jaeger format specified here. Here's an example of an existing propagator that's already implemented: https://github.com/open-telemetry/opentelemetry-python/blob/master/opentelemetry-sdk/src/opentelemetry/sdk/trace/propagation/b3_format.py |
Let me know if you'd like to take this on and I can assign it to you, thanks! |
@codeboten yep, I'll take this one! |
Assigned, thanks! |
Hi, @codeboten, the implementation of the extractor function for Jaeger format requires a keys method implemented to extract keys with the prefix 'uberctx-'. I took a look at the spec discussion here and I don't see any other way out. Advice on how to proceed please! |
Hey @Rashmi-K-A, looks like it's probably worth addressing this issue first then: #1084, did you want to tackle that one? |
Someone picked it up, I'll wait for that issue to be closed before raising a PR! |
Wow that was quick, sounds good! |
As per spec, we must provide support for the Jaeger propagation format: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/context/api-propagators.md#propagators-distribution
The text was updated successfully, but these errors were encountered: