Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecordException with extra parameters #1102

Closed
codeboten opened this issue Sep 14, 2020 · 6 comments · Fixed by #1242
Closed

RecordException with extra parameters #1102

codeboten opened this issue Sep 14, 2020 · 6 comments · Fixed by #1242
Assignees
@shreyagupta30
Labels
good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release

Comments

@codeboten
Copy link
Contributor

As per the spec:

If RecordException is provided, the method MUST accept an optional parameter to provide any additional event attributes (this SHOULD be done in the same way as for the AddEvent method). If attributes with the same name would be generated by the method already, the additional attributes take precedence.
@codeboten codeboten added good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release labels Sep 14, 2020
@KKelvinLo
Copy link
Member

Hello, can I pick up this issue? cc: @alolita

@codeboten
Copy link
Contributor Author

That'd be great, thanks!

@KKelvinLo
Copy link
Member

Un-assigning myself from this issue - finished other first issues, leaving for others to try

@KKelvinLo KKelvinLo removed their assignment Oct 6, 2020
@shreyagupta30
Copy link
Contributor

Hi, @codeboten ! I am an outreachy applicant. I'd be happy to work on this issue. Can I contribute to it?

@codeboten
Copy link
Contributor Author

Sure @shreyagupta30, will assign it to you

@shreyagupta30 shreyagupta30 mentioned this issue Oct 14, 2020
Merged
@shreyagupta30
Copy link
Contributor

Hi, @codeboten! I tried solving this issue with #1242. Kindly review it and let me know the required changes.

@codeboten codeboten added the rc1 label Oct 29, 2020
@lzchen lzchen mentioned this issue Nov 2, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shreyagupta30 shreyagupta30

Labels
good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add optional parameter to record_exception method shreyagupta30/opentelemetry-python
3 participants
@codeboten @shreyagupta30 @KKelvinLo