Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate semantic convention constants/classes #1022

Closed
aabmass opened this issue Aug 19, 2020 · 3 comments · Fixed by #1759
Closed

Generate semantic convention constants/classes #1022

aabmass opened this issue Aug 19, 2020 · 3 comments · Fixed by #1759
Assignees

Comments

@aabmass
Copy link
Member

aabmass commented Aug 19, 2020

Part of #932

open-telemetry/build-tools#5 and open-telemetry/opentelemetry-specification#571 introduce a tool that feeds semantic conventions (yaml files in spec repo) into a Jinja template to generate code. It would great if we could use this to generate constants for e.g. resource semantic conventions.

They have already used this in OT java to generate some things like https://github.com/heyams/opentelemetry-java/blob/master/api/src/main/java/io/opentelemetry/trace/attributes/SemanticAttributes.java


Not needed for GA I don't think, but nice to have

@srikanthccv
Copy link
Member

@aabmass Are you still looking into this? I can take a stab at this. I think this really helps in making instrumentations to follow semantic conventions.

@aabmass
Copy link
Member Author

aabmass commented Apr 1, 2021

All yours

@aabmass aabmass assigned srikanthccv and unassigned aabmass Apr 1, 2021
@srikanthccv
Copy link
Member

srikanthccv commented Apr 8, 2021

@aabmass Where do you think these generated files should go? I can think of two options 1)Part of api(span attribute semantic conventions)/sdk(resource semconv) With this approach anybody taking dependency api/sdk can use Otel semantic conventions 2)Separate package in contrib repo (this seems good choice to me) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants