Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_correlations return value should be immutable #1020

Closed
ffe4 opened this issue Aug 19, 2020 · 0 comments · Fixed by #1024
Closed

get_correlations return value should be immutable #1020

ffe4 opened this issue Aug 19, 2020 · 0 comments · Fixed by #1024

Comments

@ffe4
Copy link
Contributor

ffe4 commented Aug 19, 2020

According to the spec:

the returned value can be either an immutable collection or an immutable iterator

Currently, we return a dict (link):

correlations = get_value(_CORRELATION_CONTEXT_KEY, context=context)
if isinstance(correlations, dict):
    return correlations.copy()
return {}

This was mentioned in the PR but not definitively addressed #471 (comment), so I thought it might be worth bringing up again before GA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant