diff --git a/examples/opentracing/README.md b/examples/opentracing/README.md index d417a6bbb2c..78b86168123 100644 --- a/examples/opentracing/README.md +++ b/examples/opentracing/README.md @@ -5,7 +5,7 @@ package](https://github.com/open-telemetry/opentelemetry-python/tree/master/ext/ to interact with libraries instrumented with [`opentracing-python`](https://github.com/opentracing/opentracing-python). -The included `rediscache` library creates spans via the OpenTelemetry Redis +The included `rediscache` library creates spans via the OpenTracing Redis integration, [`redis_opentracing`](https://github.com/opentracing-contrib/python-redis). Spans are exported via the Jaeger exporter, which is attached to the @@ -66,7 +66,7 @@ Open the Jaeger UI in your browser at Each `main.py` run should generate a trace, and each trace should include multiple spans that represent calls to Redis. -

+

Note that tags and logs (OpenTracing) and attributes and events (OpenTelemetry) from both tracing systems appear in the exported trace. diff --git a/examples/opentracing/main.py b/examples/opentracing/main.py index 2be85a44d7b..eff1b55c3da 100755 --- a/examples/opentracing/main.py +++ b/examples/opentracing/main.py @@ -34,7 +34,7 @@ def fib(n): if n < 0: raise ValueError if n == 0 or n == 1: - return 1 + return n return fib(n - 1) + fib(n - 2) diff --git a/examples/opentracing/requirements.txt b/examples/opentracing/requirements.txt index ec7c7b0e57e..d87842f4d89 100644 --- a/examples/opentracing/requirements.txt +++ b/examples/opentracing/requirements.txt @@ -1,4 +1,6 @@ opentelemetry-api +opentelemetry-sdk +opentelemetry-ext-jaeger opentelemetry-opentracing-shim redis redis_opentracing diff --git a/test b/test deleted file mode 100644 index 9daeafb9864..00000000000 --- a/test +++ /dev/null @@ -1 +0,0 @@ -test