From 10483915a1d7c10d52bcb94f9668da150a3c0664 Mon Sep 17 00:00:00 2001 From: Ben Beasley Date: Mon, 16 Aug 2021 13:45:48 -0400 Subject: [PATCH] Handle traceback.format_exception() API change in Python 3.10 (#2018) --- CHANGELOG.md | 2 ++ shim/opentelemetry-opentracing-shim/tests/test_shim.py | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 735e546a7a1..c6bd176ae94 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 to let distros use its default implementation ([#1937](https://github.com/open-telemetry/opentelemetry-python/pull/1937)) - Add Trace ID validation to meet [TraceID spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/overview.md#spancontext) ([#1992](https://github.com/open-telemetry/opentelemetry-python/pull/1992)) +- Fixed Python 3.10 incompatibility in `opentelemetry-opentracing-shim` tests + ([#2018](https://github.com/open-telemetry/opentelemetry-python/pull/2018)) ## [0.23.1](https://github.com/open-telemetry/opentelemetry-python/pull/1987) - 2021-07-26 diff --git a/shim/opentelemetry-opentracing-shim/tests/test_shim.py b/shim/opentelemetry-opentracing-shim/tests/test_shim.py index 828097270f0..e27f7797340 100644 --- a/shim/opentelemetry-opentracing-shim/tests/test_shim.py +++ b/shim/opentelemetry-opentracing-shim/tests/test_shim.py @@ -482,9 +482,7 @@ def test_span_on_error(self): ex = exc_ctx.exception expected_stack = "".join( - traceback.format_exception( - etype=type(ex), value=ex, tb=ex.__traceback__ - ) + traceback.format_exception(type(ex), value=ex, tb=ex.__traceback__) ) # Verify exception details have been added to span. exc_event = scope.span.unwrap().events[0]