-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http.server.duration
metric description is wrong
#2753
Comments
I'll try to work on this. |
@KyriosGN0, are you facing the issue with the new version? |
I found the current description of "http.server.duration" and "http.server.request.duration" is not consistent with the "open telemetry.io". |
@StevenPenn, We made recent changes in several instrumentations to make them compatible with new semantic conventions, so any suggestion is appreciated. |
Hi @emdneto, sorry for the late reply, the PR is still in compliance process. Currently, I found the "http.server.duration" is updated to "http.server.request.duration" according to the https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/#http-server-duration-metric. But in our repo, the description of "http.server.duration" and "http.server.request.duration" is mixed.
|
@StevenPenn Thanks, I noticed that. Let me know if you are open to work on this or someone else can take it over |
Sure, I am working on it and will create PR as soon as possible. And could you please assign this to me, so someone else can take other issue. |
Describe your environment
OS: K8S
Python version: 3.11
Package version: 0.46b0
What happened?
our Otel Collectors are dropping metrics caused due to a description in some metrics not being set correctly, this was fine in 0.45b0, it seems that it was reverted/overridden here
as a result we see the errors like in this issue
Steps to Reproduce
Expected Result
no errors
Actual Result
metrics being dropped as result of mismatch in description
Additional context
No response
Would you like to implement a fix?
None
The text was updated successfully, but these errors were encountered: