Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit all packages to ensure NoOpTracerProvider works #958

Open
23 of 36 tasks
codeboten opened this issue Mar 10, 2022 · 5 comments
Open
23 of 36 tasks

Audit all packages to ensure NoOpTracerProvider works #958

codeboten opened this issue Mar 10, 2022 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codeboten
Copy link
Contributor

codeboten commented Mar 10, 2022

An issue was found in the wsgi instrumentation by integration tests in the core repository. The issue should have been caught by unit tests in the instrumentation using the NoOpTracerProvider.

The outcome of this issue is to ensure each instrumentation contains a test using the NoOpTracerProvider and that it does not rely on the OpenTelemetry SDK:

@codeboten codeboten added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 10, 2022
@lzchen
Copy link
Contributor

lzchen commented Mar 17, 2022

Discussed in 3/17 SIG:

Perhaps we can modify testbaseutils for loading only an api so instrumentations can test only against the api classes

@ocelotl
Copy link
Contributor

ocelotl commented Mar 18, 2022

testbaseutils for loading only an api so instrument

Sorry, can you provide more context, please?

@srikanthccv
Copy link
Member

testbaseutils for loading only an api so instrument

Sorry, can you provide more context, please?

All the instrumentation tests inherit this TestBase. One thing we could do is to not set up provider here and see if tests produce any error in the absence of sdk tracer provider.

@ocelotl
Copy link
Contributor

ocelotl commented Mar 21, 2022

testbaseutils for loading only an api so instrument

Sorry, can you provide more context, please?

All the instrumentation tests inherit this TestBase. One thing we could do is to not set up provider here and see if tests produce any error in the absence of sdk tracer provider.

Got it, thanks ✌️

@zhihali
Copy link
Contributor

zhihali commented Jul 21, 2024

I have checked and found the Celery and Starlette is merged and could be marked finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants