Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process Request] Request PyPi and testPyPi tokens for releasing sqlcommenter-python library #845

Closed
sjs994 opened this issue Jan 7, 2022 · 7 comments

Comments

@sjs994
Copy link

sjs994 commented Jan 7, 2022

SQLCommenter is a library donated by Google to OpenTelemetry. We are in a process to of migrating the source code from google-cloud-sqlcommenter to opentelemetry-sqlcommenter.

SQLCommenter contains middleware/plugins that adds the capability of instrumenting SQL queries with code that executes the queries i.e. information like action, controller, dbdriver, etc and opentelemetry-trace(if present). More Details here

One of the supported language is Python, which includes django, flask frameworks and ORMs like sqlalchemy and psycopg2 (https://github.com/open-telemetry/opentelemetry-sqlcommenter/tree/main/python/sqlcommenter-python).

For the process of migration, we have moved in the code, documentation and renamed the packages to point to opentelemetry instead of google-cloud. Now our next task is to publish the packages into PyPi and TestPyPi. From the Python SIG meeting, my understanding is we would need tokens (restricted to only sqlcommenter project) to release these libraries. Can someone help us with this process ?

cc: @lonewolf3739 @aabmass

@lzchen
Copy link
Contributor

lzchen commented Jan 7, 2022

@sjs994
Apologies for not being there during when this was brought up in the SIG. Is this simply going to be another instrumentation for OpenTelemetry?

@sjs994
Copy link
Author

sjs994 commented Jan 8, 2022

@lzchen the end goal is to integrate these instrumentation with OpenTelemetry, which is supposed to be the next discussion (The library is going to deal with database instrumentation and tracing and might require some discussion on the specs).

For now, the code lives in 2 places in github, within google and opentelemetry and it's difficult to maintain and support. We want to start publishing the packages from open-telemetry based repository and maybe deprecate the google-sqlcommenter repository.

When we have a published version from open-telemetry, we can start discussion on how to integrate/merge the libraries into contrib repositories of respective languages.

@owais
Copy link
Contributor

owais commented Feb 3, 2022

Was this resolved or do you still need help @sjs994 ?

@sjs994
Copy link
Author

sjs994 commented Feb 3, 2022

Thanks @owais. We will close this ticket.
We are going ahead to try some POCs to integrate the changes into opentelemetry-python-contrib repository instead of publishing from the independent repository.

@sjs994 sjs994 closed this as completed Feb 3, 2022
@srikanthccv
Copy link
Member

@sjs994 I believed that getting this https://github.com/open-telemetry/opentelemetry-sqlcommenter/tree/main/docs/specifications approved from TC review and moved to spec was necessary before adding the components to contrib repos. Is that still the plan?

@sjs994
Copy link
Author

sjs994 commented Feb 3, 2022

@lonewolf3739 from discussion with opentelemetry-java maintainers, it seem we can put sqlcommenter behind an experimental flag.

If that is possible with opentelemetry-python-contrib repository, we can start the effort in parallel instead of waiting for the specs to be fully approved.

@srikanthccv
Copy link
Member

Thanks, it's great to see you decided to choose this route. We can certainly enable this as an experimental feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants