Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of the box support for Gunicorn #676

Open
owais opened this issue Sep 10, 2021 · 2 comments
Open

Out of the box support for Gunicorn #676

owais opened this issue Sep 10, 2021 · 2 comments

Comments

@owais
Copy link
Contributor

owais commented Sep 10, 2021

Setting up OpenTelemetry needs additional manual steps when working with gunicorn as documented here: https://opentelemetry-python.readthedocs.io/en/latest/examples/fork-process-model/README.html#gunicorn-post-fork-hook

This should not be required if a user is invokes the opentelemetry-instrument command to auto-instrument their gunicorn based service.

Hint: pre instrumentation hook might be helpful to implement this.

@adriangb
Copy link
Contributor

Clarifying question: this is not a problem if users instrument from within a forked process right? They'd just get a lock within each process, which works fine.

@adamantike
Copy link
Contributor

@adriangb, I think that's right. I'm currently using the approach detailed in #385 (comment), which instruments each process as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants