Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flask] Replace span name callback with request and response hooks #410

Closed
owais opened this issue Apr 5, 2021 · 2 comments
Closed

[Flask] Replace span name callback with request and response hooks #410

owais opened this issue Apr 5, 2021 · 2 comments
Assignees
@NickSulistio
Labels
feature-request good first issue Good for newcomers instrumentation

Comments

@owais
Copy link
Contributor

owais commented Apr 5, 2021

Flask instrumentation accepts a span name callback which should be replaced with more generic request/response callbacks (hooks).

Details: #408
@NickSulistio
Copy link
Contributor

I'll pick this up!

cc @alolita

@NickSulistio NickSulistio mentioned this issue Apr 29, 2021
Closed
6 tasks
@NickSulistio
Copy link
Contributor

Should we close this issue now? @lzchen

@lzchen lzchen closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickSulistio NickSulistio

Labels
feature-request good first issue Good for newcomers instrumentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@owais @lzchen @NickSulistio