Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development workflow should not run "sudo" #3187

Open
michaelsafyan opened this issue Jan 14, 2025 · 0 comments
Open

Development workflow should not run "sudo" #3187

michaelsafyan opened this issue Jan 14, 2025 · 0 comments

Comments

@michaelsafyan
Copy link

Running tox causes it to call sudo:

generate-workflows: OK ✔ in 4.59 seconds
shellcheck: recreate env because python changed virtualenv version='20.26.2'->'20.28.1'
shellcheck: remove tox env folder /usr/local/google/home/michaelsafyan/Code/github/michaelsafyan/open-telemetry.opentelemetry-python-contrib/.tox/shellcheck
shellcheck: commands_pre[0]> sh -c 'sudo apt update -y && sudo apt install --assume-yes shellcheck'
[sudo] password for michaelsafyan: 

It looks like it is attempting to install shellcheck. I already have this installed on my system:

$ shellcheck --version
ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net

But it would be even better, if there are external dependencies like this, to use a container with podman (or to use something like nix-shell) to ensure that the version of the tool is repeatable. At the very least, though, this step should be skipped if the tool is already installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant