Support enable_commenter for instrument_connection by psycopg(2 #3071
+385
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
force-pushed
the
enable-commenter-instrument-connection
branch
from
b102323 to
bf49c8c
Compare
github-actions
bot
assigned codeboten, NathanielRN, nikosokolik, oxeye-nikolay, shalevr and srprash
tammy-baylis-swi
unassigned federicobond, codeboten, NathanielRN, srprash, shalevr, nikosokolik and oxeye-nikolay
tammy-baylis-swi
force-pushed
the
enable-commenter-instrument-connection
branch
from
4f969ef to
e148c9f
Compare
|
Sorry to drag in several participants automatically! I committed changes I didn't mean to, and it's fixed now. |
lzchen
reviewed
Jan 14, 2025
| connection: psycopg.Connection, | ||
| tracer_provider: typing.Optional[trace_api.TracerProvider] = None, | ||
| enable_commenter: bool = False, | ||
| commenter_options: dict = None, |
There was a problem hiding this comment.
Do we want enable_attribute_commenter as well?
There was a problem hiding this comment.
Yes! Added in 3587846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3070
Depends on #3043 to stop errors with manual tests (instrumenting an app and calling
instrument_connection). Fixes docs and there will be merge conflicts.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e py312-test-instrumentation-psycopg2tox -e py312-test-instrumentation-psycopgPsycopg2Instrumentor.instrument_connectionPsycopgInstrumentor.instrument_connectionDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.