You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #243 we add performance tests for the AWS SDK Extension.
The AWS SDK extension falls under the category sdkextension of tests matched in the build workflow. For this reason, when the jq command looks through the entire repo after the workflow for *-benchmark.json files we are guaranteed to find at least ` file. This file is then given to the subsequent Github action to report on benchmarking results.
However, the build workflow also has instrumentation and exporter packages. These don't have performance tests yet so the jq command will fail. Even if we suppress the failure, the subsequent GitHub action will fail if no valid output.json file is created.
A temporary solution was to only run those 2 steps of the workflow if: matrix.package == 'sdkextension'. A more long-term solution will be to add benchmarks to instrumentation and exporter.
We should probably keep this open until we have benchmarks for all relevant contrib packages (and a relevant way to force new packages to include them)!
In #243 we add performance tests for the AWS SDK Extension.
The AWS SDK extension falls under the category
sdkextension
of tests matched in thebuild
workflow. For this reason, when thejq
command looks through the entire repo after the workflow for*-benchmark.json
files we are guaranteed to find at least ` file. This file is then given to the subsequent Github action to report on benchmarking results.However, the
build
workflow also hasinstrumentation
andexporter
packages. These don't have performance tests yet so thejq
command will fail. Even if we suppress the failure, the subsequent GitHub action will fail if no validoutput.json
file is created.A temporary solution was to only run those 2 steps of the workflow
if: matrix.package == 'sdkextension'
. A more long-term solution will be to add benchmarks toinstrumentation
andexporter
.opentelemetry-python-contrib/.github/workflows/test.yml
Lines 61 to 62 in 91bfc9a
and
opentelemetry-python-contrib/.github/workflows/test.yml
Lines 68 to 69 in 91bfc9a
We know only these packages are required because as long as subsequent tests fit under these categories we won't have to keep adding
if
statements.The text was updated successfully, but these errors were encountered: