Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure pymysql instrumentation follows semantic conventions #1628

Open
Tracked by #1624
srikanthccv opened this issue Feb 4, 2023 · 4 comments
Open
Tracked by #1624

Make sure pymysql instrumentation follows semantic conventions #1628

srikanthccv opened this issue Feb 4, 2023 · 4 comments
Assignees
@Anu-MT
Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation

Comments

@srikanthccv
Copy link
Member

No description provided.

@srikanthccv srikanthccv mentioned this issue Feb 4, 2023
Open
12 tasks
@srikanthccv srikanthccv added good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Feb 4, 2023
@Anu-MT
Copy link

Anu-MT commented Aug 1, 2023

Hi,
I would like to work on the issue. Would you assign this to me?Any guidance will be greatly appreciated.

@srikanthccv
Copy link
Member Author

pymysql instrumentation adds several attributes to the spans it creates. Some of them could be outside the semantic conventions defined for databases here https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/README.md. We need to update the instrumentation to follow the updated semantic conventions.

@Joice-crypto
Copy link

Hello, is anyone currently working on this? Could I give it a try?

@emdneto
Copy link
Member

emdneto commented Oct 15, 2024

@Joice-crypto sure. Please feel free to open a PR

@Joice-crypto Joice-crypto mentioned this issue Oct 19, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anu-MT Anu-MT

Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@emdneto @Anu-MT @srikanthccv @Joice-crypto