Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request and response hooks to fastapi instrumentation #136

Closed
lzchen opened this issue Nov 3, 2020 · 2 comments
Closed

Add request and response hooks to fastapi instrumentation #136

lzchen opened this issue Nov 3, 2020 · 2 comments
Labels
feature-request good first issue Good for newcomers help wanted Extra attention is needed instrumentation

Comments

@lzchen
Copy link
Contributor

lzchen commented Nov 3, 2020 •
edited by owais
Loading

Accept a request and response hook functions in FastAPIInstrumentor().instrument.

Details: #408
@codeboten codeboten transferred this issue from open-telemetry/opentelemetry-python Nov 5, 2020
@codeboten codeboten added good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Nov 5, 2020
@owais owais changed the title Add hook to set custom span name in fastapi instrumentation Add request and response hooks to fastapi instrumentation Apr 5, 2021
@owais owais assigned owais and unassigned owais Apr 8, 2021
@github-actions
Copy link

github-actions bot commented May 9, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@ryokather ryokather mentioned this issue Jul 12, 2021
Merged
7 tasks
@lzchen
Copy link
Contributor Author

lzchen commented Sep 13, 2021

Finished with #576

@lzchen lzchen closed this as completed Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request good first issue Good for newcomers help wanted Extra attention is needed instrumentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@owais @codeboten @lzchen @srikanthccv