Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstrument Existing fastapi instances #1256

Closed
TheAnshul756 opened this issue Sep 1, 2022 · 1 comment · Fixed by #1258
Closed

Uninstrument Existing fastapi instances #1256

TheAnshul756 opened this issue Sep 1, 2022 · 1 comment · Fixed by #1258
Assignees
@TheAnshul756

Comments

@TheAnshul756
Copy link
Contributor

TheAnshul756 commented Sep 1, 2022 •
edited
Loading

Existing instances shouldn't continue to send any telemetry after the uninstrument.

Originally posted by @srikanthccv in #1199 (comment)

uninstrument method of FastAPIInstrumentor restore the original fastapi.FastAPI class, but all the existing objects of the earlier instrumented class do not get uninstrumented, which is not the expected behaviour.
@TheAnshul756 TheAnshul756 changed the title Uninstrument Existing fastapi instance Uninstrument Existing fastapi instances Sep 1, 2022
@TheAnshul756
Copy link
Contributor Author

@srikanthccv please assign this to me.

@TheAnshul756 TheAnshul756 mentioned this issue Sep 1, 2022
Merged
6 tasks
@TheAnshul756 TheAnshul756 mentioned this issue Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheAnshul756 TheAnshul756

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@TheAnshul756