From 511709802466a751786047b7d98c2eb84801b34f Mon Sep 17 00:00:00 2001 From: Diego Hurtado Date: Tue, 25 Apr 2023 11:44:11 -0600 Subject: [PATCH] Fix expected URL in aiohttp instrumentation test (#1772) * WIP * Revert "WIP" This reverts commit 3ed466348e4c172fd96569a0dcb1b15047760cef. * Fix expected URL in aiohttp instrumentation test The underlying cause of the issue here is the update of the yarl package from 1.8.2 to 1.9.1. yarl is used as a dependency in the opentelemetry-instrumentation-aiohttp package but it is not there where the issue happens, but in aiohttp who also has yarl as a dependency. This is why the fix does not touch any relevant part of any opentelemetry-* code, since it is the return value of aiohttp code who now has a different value for the URL. Fixes #1770 --- .../tests/test_aiohttp_client_integration.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py b/instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py index 9210dae702..d9f76f0239 100644 --- a/instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py +++ b/instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py @@ -122,7 +122,7 @@ def test_status_codes(self): (span_status, None), { SpanAttributes.HTTP_METHOD: "GET", - SpanAttributes.HTTP_URL: f"http://{host}:{port}/test-path?query=param#foobar", + SpanAttributes.HTTP_URL: f"http://{host}:{port}/test-path#foobar", SpanAttributes.HTTP_STATUS_CODE: int( status_code ),