profiles: drop Location.type_index #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With open-telemetry/semantic-conventions#1188 the semantic convention for Profiles that introduces frame types and well known values is about to be merged. Therefore, `Location.type_index` is no longer needed. FYI: @open-telemetry/profiling-maintainers
Kielek
reviewed
Aug 29, 2024
aalexand
approved these changes
Aug 29, 2024
This was referenced Sep 10, 2024
|
Please resolve the conversations so that we can merge. |
dmathieu
pushed a commit
to dmathieu/opentelemetry-proto
that referenced
this pull request
Sep 23, 2024
With open-telemetry/semantic-conventions#1188 the semantic convention for Profiles that introduces frame types and well known values is about to be merged. Therefore, `Location.type_index` is no longer needed. FYI: @open-telemetry/profiling-maintainers Co-authored-by: Tigran Najaryan <[email protected]>
florianl
added a commit
to open-telemetry/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 24, 2024
With open-telemetry/semantic-conventions#1188 a semantic convention for frame types was defined and open-telemetry/opentelemetry-proto#578 removed Location.type_index from the OTel profiling signal in favor of the semantic convention. Update the reporter to use this semantic convention. Signed-off-by: Florian Lehner <[email protected]>
florianl
added a commit
to open-telemetry/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 24, 2024
With open-telemetry/semantic-conventions#1188 a semantic convention for frame types was defined and open-telemetry/opentelemetry-proto#578 removed Location.type_index from the OTel profiling signal in favor of the semantic convention. Update the reporter to use this semantic convention. Signed-off-by: Florian Lehner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With open-telemetry/semantic-conventions#1188 the semantic convention for Profiles that introduces frame types and well known values is about to be merged.
Therefore,
Location.type_indexis no longer needed.FYI: @open-telemetry/profiling-maintainers
Similar to #575 this is a breaking change. And CI can only pass, once #576 is merged.