Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to explain schema_url fields #504

Conversation

tigrannajaryan
Copy link
Member

Resolves #502

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One not-blocking comment.

opentelemetry/proto/logs/v1/logs.proto Outdated Show resolved Hide resolved
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/explainschemaurl branch from dfa2a7f to e150ad3 Compare August 23, 2023 11:51
@tigrannajaryan tigrannajaryan merged commit d1468b7 into open-telemetry:main Aug 23, 2023
@tigrannajaryan tigrannajaryan deleted the feature/tigran/explainschemaurl branch August 23, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The comment of schema_url doesn't describe it's purpose.
5 participants