perf: Re-use empty resource instance #1251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
While searching for low-hanging fruits to improve performance, it appeared from a profile of mine that repeated calls to
ResourceInfoFactory::emptyResource
would start having a non-negligible impact on the performances.The instance - being immutable - could be re-used.
Note: I haven't added a test with this PR as imo this is already been tested through the numerous calls to
ResourceInfoFactory::emptyResource
Thanks! 😃
FYI, this is the code I used to generate the above profile, if you care, which I ran a few dozen thousand times: