Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for "per-node" allocation strategy #3477

Closed
lhp-nemlig opened this issue Nov 20, 2024 · 0 comments · Fixed by #3482
Closed

Add fallback for "per-node" allocation strategy #3477

lhp-nemlig opened this issue Nov 20, 2024 · 0 comments · Fixed by #3482
Labels
enhancement New feature or request needs triage

Comments

@lhp-nemlig
Copy link
Contributor

lhp-nemlig commented Nov 20, 2024

Component(s)

target allocator

Is your feature request related to a problem? Please describe.

The operator does not allow me to deploy a daemonset collector with any other allocation strategy than per-node. This is very reasonable, but if I add a prometheus scrape job that scrapes a single non-node-specific target it will not be allocated as that is currently the expected functionality of the "per-node" allocation strategy.

See below example of failure to deploy as daemonset with "consistent-hashing" allocation strategy.

Error: UPGRADE FAILED: an error occurred while rolling back the release. original upgrade error: cannot patch "opentelemetry" with kind OpenTelemetryCollector: admission webhook "vopentelemetrycollectorcreateupdatebeta.kb.io" denied the request: the OpenTelemetry Collector mode is set to daemonset, which must be used with target allocation strategy per-node

Describe the solution you'd like

I think there should be a fallback, ideally just using "consistent-hashing" or "least-weighted" for the leftover targets after "per-node" allocation is done.

Describe alternatives you've considered

No response

Additional context

The possibility of adding a fallback was talked about in this issue, but never acted upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
1 participant