Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine better strategy for handling map merging for various fields #2947

Closed
jaronoff97 opened this issue May 10, 2024 · 4 comments · Fixed by #3324
Closed

Determine better strategy for handling map merging for various fields #2947

jaronoff97 opened this issue May 10, 2024 · 4 comments · Fixed by #3324
Assignees
@davidhaja
Labels
area:collector Issues for deploying collector enhancement New feature or request help wanted Extra attention is needed

Comments

@jaronoff97
Copy link
Contributor

Right now we have to manually clear maps for only the node selector in the mutate.go, but i'm sure there are other places where we shouldn't blindly merge things together.

Originally posted by @swiatekm-sumo in #2941 (review)
@jaronoff97 jaronoff97 added enhancement New feature or request area:collector Issues for deploying collector labels May 10, 2024
@swiatekm
Copy link
Contributor

In reality, I think the logic here should be very simple. We should clear everything except labels and annotations, and even in their case I'm not completely convinced this is a good idea. It's another question whether this is actually straightforward to do with our current tooling.

@swiatekm swiatekm added the discuss-at-sig This issue or PR should be discussed at the next SIG meeting label May 14, 2024
@jaronoff97
Copy link
Contributor Author

Yeah maybe this is worth doing for everything... if anyone reading this wants to check it out do reach out!

@jaronoff97 jaronoff97 added help wanted Extra attention is needed and removed discuss-at-sig This issue or PR should be discussed at the next SIG meeting labels May 23, 2024
@davidhaja
Copy link
Contributor

I would like to work on this.

@jaronoff97
Copy link
Contributor Author

thanks @davidhaja :D Let me know if you need any assistance 🙇

@davidhaja davidhaja mentioned this issue Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhaja davidhaja

Labels
area:collector Issues for deploying collector enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@jaronoff97 @davidhaja @swiatekm