Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OpenTelemetryCollector readinessProbe #2943

Closed
janario opened this issue May 9, 2024 · 1 comment · Fixed by #2944
Closed

Support for OpenTelemetryCollector readinessProbe #2943

janario opened this issue May 9, 2024 · 1 comment · Fixed by #2944
Labels
enhancement New feature or request needs triage

Comments

@janario
Copy link
Contributor

janario commented May 9, 2024

Component(s)

collector

Is your feature request related to a problem? Please describe.

We were testing high-availability of the collector (managed by the operator) while we roll out changes and we noticed that the Pods created by the operator don't have readinessProbe configured.

Describe the solution you'd like

Support readinessProbe for the collector pods using the default as provided by the chart https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/values.yaml#L397

Describe alternatives you've considered

No response

Additional context

We could achieve high-availability while rolling out with readinessProbe(to be addressed here) and some sleep at the preStop (really custom image, to be addressed at the collector repo later).

@janario janario added enhancement New feature or request needs triage labels May 9, 2024
@janario
Copy link
Contributor Author

janario commented May 9, 2024

We should have a PR for this one by tomorrow :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant