Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service.instance.id is not added because of empty podName #2679

Closed
janario opened this issue Feb 26, 2024 · 0 comments · Fixed by #2678
Closed

service.instance.id is not added because of empty podName #2679

janario opened this issue Feb 26, 2024 · 0 comments · Fixed by #2678
Labels
bug Something isn't working needs triage

Comments

@janario
Copy link
Contributor

janario commented Feb 26, 2024

Component(s)

No response

What happened?

Description

Some providers require the service.instance.id to be present in order to group some of their metrics.

But noticed into our scenarios that while the pod is being created the name may be empty and service.instance.id would not be provided.

Related to: open-telemetry/semantic-conventions#312

Fix at: #2678

Steps to Reproduce

Expected Result

service.instance.id should be added to the pod attibutes

Actual Result

Absence of service.instance.id due to pod name be empty

Kubernetes Version

1.25

Operator version

0.93.0 (0.47.0 chart)

Collector version

0.93.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Log output

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant