Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator errors when opamp bridge image is pinned to a specific sha #2583

Closed
jdcrouse opened this issue Jan 30, 2024 · 2 comments · Fixed by #2758
Closed

Operator errors when opamp bridge image is pinned to a specific sha #2583

jdcrouse opened this issue Jan 30, 2024 · 2 comments · Fixed by #2758
Assignees
Labels
bug Something isn't working needs triage

Comments

@jdcrouse
Copy link
Contributor

Component(s)

operator, opamp bridge

What happened?

Description

The operator is attempting to set the entire sha as a label when pinning the bridge to a specific sha, which is too long and leads to an error that prevents the bridge from being created

Steps to Reproduce

Configure an opamp bridge with the image set to a specific git sha from here
example:

image: "ghcr.io/open-telemetry/opentelemetry-operator/operator-opamp-bridge:main@sha256:00738c3a6bca8f143995c9c89fd0c1976784d9785ea394fcdfe580fb18754e1e"

Expected Result

The operator would successfully create an opamp bridge with the desired image version

Actual Result

The opamp bridge gets stuck on container creation and the operator spits out the error below (the sha is being set as a label, but the value is not truncated so it will always be too long)

"error":"ConfigMap \"dev-opamp-bridge-opamp-bridge\" is invalid: metadata.labels: Invalid value: \"00738c3a6bca8f143995c9c89fd0c1976784d9785ea394fcdfe580fb18754e1e\": must be no more than 63 characters"

Kubernetes Version

1.28.3

Operator version

0.92.1

Collector version

0.92.0

Environment information

No response

Log output

"error":"ConfigMap \"dev-opamp-bridge-opamp-bridge\" is invalid: metadata.labels: Invalid value: \"00738c3a6bca8f143995c9c89fd0c1976784d9785ea394fcdfe580fb18754e1e\": must be no more than 63 characters"

Additional context

No response

@jdcrouse jdcrouse added bug Something isn't working needs triage labels Jan 30, 2024
@jaronoff97
Copy link
Contributor

jaronoff97 commented Jan 30, 2024

part of this is related to #2399. It would be great if we could bubble this up to the user when they apply CRDs rather than opaque operator logs. The solution here will involve fixing the SHA, but to me the real issue that we created manifests that were invalid. i.e. the deployment was created but because the configmap wasn't the pod was stuck in containercreating.

@jaronoff97
Copy link
Contributor

Kristina has offered to work on this :) 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
3 participants