-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename OPENTELEMETRY_COLLECTOR_CONFIG_FILE to appropriate usage #645
Comments
I would suggest using We should ensure that we continue to support the prior variable for some period of time as a fallback if the new variable is not populated. We should emit a warning into the logs if the old variable is used. |
This issue was marked stale. It will be closed in 30 days without additional activity. |
Closed as inactive. Feel free to reopen if this issue is still relevant. |
Still relevant. The name cause some confusion for me initially. |
Certainly open to PRs if someone wants to contribute this change. LMK and I can reopen the issue. |
Would the original name have to be kept for backwards compatibility? |
Assuming that would not be difficult, I'd say yes. |
What's the process for deprecating env vars in this case? |
We don't have any documented process. I would mainly suggest remove it from the documentation so people start using the new one going forward. |
@tylerbenson can you reopen this issue so that it can be properly closed as complete if/when my PR is merged? |
Currently
OPENTELEMETRY_COLLECTOR_CONFIG_FILE
is a environment variable used to set the config file from any of the config map providers such as http, s3, yaml. etc., as per the naming convention it is not exactly a file as the input to this variable could be URI format example here. Hence creating this issue to see if this can be renamed toOPENTELEMETRY_COLLECTOR_CONFIG
instead.The text was updated successfully, but these errors were encountered: