Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing support to java8 runtime #1442

Closed
rapphil opened this issue Jul 18, 2024 · 8 comments · Fixed by #1481
Closed

Consider removing support to java8 runtime #1442

rapphil opened this issue Jul 18, 2024 · 8 comments · Fixed by #1481
Assignees
Labels
bug Something isn't working

Comments

@rapphil
Copy link
Contributor

rapphil commented Jul 18, 2024

Describe the bug
Java8 support is reaching end of the life. No new function can be created with the Java8 runtime.
https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html#runtimes-deprecated

Steps to reproduce
Try to create a new function that uses java8.

What did you expect to see?
That opentelemetry-lambda did not support java8.

What did you see instead?
Java8 is still supported.

Additional context
It is ok to deprecate java8 in my opinion because we still will support java8.al2.
https://aws.amazon.com/blogs/compute/announcing-migration-of-the-java-8-runtime-in-aws-lambda-to-amazon-corretto/

@rapphil rapphil added the bug Something isn't working label Jul 18, 2024
@tylerbenson
Copy link
Member

Sounds reasonable to me.

@knarfli
Copy link
Contributor

knarfli commented Jul 19, 2024

I want to take a look into it.

@rapphil
Copy link
Contributor Author

rapphil commented Jul 22, 2024

@knarfli feel free to take a look into it. It should be a simple change in our release scripts. Thanks for the interest.

@knarfli
Copy link
Contributor

knarfli commented Jul 23, 2024

Thanks @rapphil , I am working on that and will create a PR.

@serkan-ozal
Copy link
Contributor

I agree on this too. I think, we will just remove java8 from supported runtimes in the layer, right? Is there anything to do?

@tylerbenson
Copy link
Member

I think that's all that's required.

@knarfli
Copy link
Contributor

knarfli commented Aug 17, 2024

yes, agree with that, I have raised a pull request in a forked repository, but I need to follow some steps which block making the pull request here, let me try to speed it up.

@knarfli
Copy link
Contributor

knarfli commented Aug 21, 2024

Pull request opened, #1481.
Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants