From 069e45f748a6a8a0f3a13354d0757ac4e136506f Mon Sep 17 00:00:00 2001 From: Naseem Date: Sat, 11 Apr 2020 20:34:28 -0400 Subject: [PATCH] fix: use url.URL url.URL from the standard library should be used instead of the global URL which comes from the dom lib. Signed-off-by: Naseem --- packages/opentelemetry-plugin-http/src/http.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/opentelemetry-plugin-http/src/http.ts b/packages/opentelemetry-plugin-http/src/http.ts index 53bbebe5bbd..51263cc89e0 100644 --- a/packages/opentelemetry-plugin-http/src/http.ts +++ b/packages/opentelemetry-plugin-http/src/http.ts @@ -145,7 +145,7 @@ export class HttpPlugin extends BasePlugin { protected _getPatchOutgoingGetFunction( clientRequest: ( - options: RequestOptions | string | URL, + options: RequestOptions | string | url.URL, ...args: HttpRequestArgs ) => ClientRequest ) { @@ -161,7 +161,7 @@ export class HttpPlugin extends BasePlugin { // https://nodejs.org/dist/latest/docs/api/http.html#http_http_get_options_callback // https://github.com/googleapis/cloud-trace-nodejs/blob/master/src/plugins/plugin-http.ts#L198 return function outgoingGetRequest< - T extends RequestOptions | string | URL + T extends RequestOptions | string | url.URL >(options: T, ...args: HttpRequestArgs): ClientRequest { const req = clientRequest(options, ...args); req.end();