From 70d66ba26b37e7a7d58cc1fbfcc5a23bb535e7b2 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Tue, 17 Dec 2024 11:09:21 +0100 Subject: [PATCH 1/4] fix(ci): adapt workflow to use correct npm versions --- .github/workflows/benchmark.yml | 2 +- .github/workflows/unit-test.yml | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 5227ce2b491..79dea2c71dc 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -10,7 +10,7 @@ jobs: fail-fast: false matrix: node_version: - - "18" + - "22" runs-on: self-hosted timeout-minutes: 10 env: diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index bba8e5347f7..a47bf6026d0 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -38,6 +38,10 @@ jobs: - run: npm install -g npm@"<10.0.0" if: ${{ matrix.node_version == '14' || matrix.node_version == '16' }} + # npm@11.0.0 drops support for Node.js v18 + - run: npm install -g npm@"<11.0.0" + if: ${{ matrix.node_version == '18'}} + - name: Bootstrap run: npm ci @@ -65,7 +69,7 @@ jobs: cache: 'npm' cache-dependency-path: | package-lock.json - node-version: '18' + node-version: '22' - run: npm install -g npm@latest From aabc68fc687d6dbf786e0bc6b1f7328357fad676 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Tue, 17 Dec 2024 13:01:30 +0100 Subject: [PATCH 2/4] fixup! fix(ci): adapt workflow to use correct npm versions --- .github/workflows/unit-test.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index a47bf6026d0..59baf033c32 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -32,7 +32,7 @@ jobs: node-version: ${{ matrix.node_version }} - run: npm install -g npm@latest - if: ${{ matrix.node_version == '18' || matrix.node_version == '20' || matrix.node_version == '22' }} + if: ${{ matrix.node_version == '20' || matrix.node_version == '22' }} # npm@10.0.0 drops support for Node.js v14 and v16 - run: npm install -g npm@"<10.0.0" @@ -69,9 +69,10 @@ jobs: cache: 'npm' cache-dependency-path: | package-lock.json - node-version: '22' + node-version: '18' - - run: npm install -g npm@latest + # npm@11.0.0 drops support for Node.js v18 + - run: npm install -g npm@"<11.0.0" - name: Bootstrap run: npm ci From 727961073ef2b39fbf85bb86317d917858c9d518 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Tue, 17 Dec 2024 13:05:25 +0100 Subject: [PATCH 3/4] fixup! fix(ci): adapt workflow to use correct npm versions --- .github/workflows/unit-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 59baf033c32..1056c721dfe 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -72,7 +72,7 @@ jobs: node-version: '18' # npm@11.0.0 drops support for Node.js v18 - - run: npm install -g npm@"<11.0.0" + - run: npm install -g npm@<11.0.0 - name: Bootstrap run: npm ci From 41a1ef397acfd022fa8f7fafc626d1e17ab1fe3d Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Tue, 17 Dec 2024 14:19:52 +0100 Subject: [PATCH 4/4] fixup! fix(ci): adapt workflow to use correct npm versions --- .github/workflows/unit-test.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 1056c721dfe..32b62cfacfb 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -69,10 +69,9 @@ jobs: cache: 'npm' cache-dependency-path: | package-lock.json - node-version: '18' + node-version: '20' - # npm@11.0.0 drops support for Node.js v18 - - run: npm install -g npm@<11.0.0 + - run: npm install -g npm@latest - name: Bootstrap run: npm ci