[sdk-metrics] remove MetricAdvice type workaround

[pichlermarc]

Description

Important

Only actionable for next branch. Any PRs opened for this MUST be based on and targeted at the next branch.

In @opentelemetry/sdk-metrics some features were introduced that could not use @opentelemetry/api types that were introduced after 1.3.0. Dropping support for older API vesions would be a breaking change. As a workaround, we duplicated the types from @opentelemetry/api in @opentelemetry/sdk-metrics.

The goal of this issue is to remove these workarounds, and to use the @opentelemetry/api types directly instead.

This issue is considered done when:

• the type for the adviceproperty is replaced with MetricAdvice from @opentelemetry/api
• the minimum peerDependency version on @opentelemetry/api is raised to at least the version that is documented in the @since version of the API's MetricAdvice type (1.7.0)

Additional context

• link to code where the type needs to be replaced:

  opentelemetry-js/packages/sdk-metrics/src/InstrumentDescriptor.ts

  Lines 46 to 58 in fc94e46

  	/**
  	* @experimental
  	*
  	* This is intentionally not using the API's type as it's only available from @opentelemetry/api 1.7.0 and up.
  	* In SDK 2.0 we'll be able to bump the minimum API version and remove this workaround.
  	*/
  	readonly advice: {
  	/**
  	* Hint the explicit bucket boundaries for SDK if the metric has been
  	* aggregated with a HistogramAggregator.
  	*/
  	explicitBucketBoundaries?: number[];
  	};

• PR that introduced this workaround: fix(sdk-metrics): hand-roll MetricAdvice type as older API versions do not include it #4260

[chancancode]

closed by #5254