-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enumerate caching paths manually #514
ci: enumerate caching paths manually #514
Conversation
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
==========================================
- Coverage 90.39% 90.34% -0.05%
==========================================
Files 144 142 -2
Lines 7277 7222 -55
Branches 643 641 -2
==========================================
- Hits 6578 6525 -53
+ Misses 699 697 -2
|
6fa8ac5
to
04ee361
Compare
edit: good to go now |
5620616
to
b7adb5b
Compare
49988c4
to
42ddb88
Compare
233200a
to
0381bfb
Compare
0381bfb
to
bbe0a58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i don't know if it's possible but we could try to automate the enumeration (using lerna list
) of all packages so we don't forget to add them there.
Unfortunately no it isn't possible. Each path has to be manually entered into the paths array. There are a number of issues open with circle ci to remedy the issue but we probably have to wait for circle config 3.0 for that. |
@vmarchaud @bg451 @markwolff and those yet to review, do you think we should remove the Prior to this change nothing was cached, so this would not be different behavior to what we're already used to. |
09143fd
to
68d2143
Compare
68d2143
to
d16e80b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a minor comment
@mayurkale22 I think everything is resolved here. afaik this is ready for merge |
Somehow, all dependencies are getting installed for each job => https://circleci.com/workflow-run/5e613ca4-ce88-4529-87f6-3cdcba5c6496. Could you please verify the behavior? |
Which problem is this PR solving?
Short description of the changes