From 78bceeffd2ed344e138b30fb77f104e691bc9273 Mon Sep 17 00:00:00 2001 From: Amir Blum Date: Fri, 10 May 2024 10:04:55 +0300 Subject: [PATCH 1/3] chore: CHANGLOG --- experimental/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 20e3fbfdab..674aed2f56 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -29,6 +29,8 @@ All notable changes to experimental packages in this project will be documented ### :books: (Refine Doc) +* docs(instrumentation): better docs for supportedVersions option [#4693](https://github.com/open-telemetry/opentelemetry-js/pull/4693) @blumamir + ### :house: (Internal) ## 0.51.0 From e1094755cb34275b8e81e9172384277095c645c1 Mon Sep 17 00:00:00 2001 From: Amir Blum Date: Fri, 10 May 2024 10:27:33 +0300 Subject: [PATCH 2/3] fix(instrumentation): remove unused property from instrumentations --- experimental/CHANGELOG.md | 2 -- .../opentelemetry-instrumentation/src/types.ts | 10 ---------- 2 files changed, 12 deletions(-) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 674aed2f56..20e3fbfdab 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -29,8 +29,6 @@ All notable changes to experimental packages in this project will be documented ### :books: (Refine Doc) -* docs(instrumentation): better docs for supportedVersions option [#4693](https://github.com/open-telemetry/opentelemetry-js/pull/4693) @blumamir - ### :house: (Internal) ## 0.51.0 diff --git a/experimental/packages/opentelemetry-instrumentation/src/types.ts b/experimental/packages/opentelemetry-instrumentation/src/types.ts index 3adc03921d..0445192de1 100644 --- a/experimental/packages/opentelemetry-instrumentation/src/types.ts +++ b/experimental/packages/opentelemetry-instrumentation/src/types.ts @@ -54,14 +54,6 @@ export interface Instrumentation< /** Method to get instrumentation config */ getConfig(): ConfigType; - - /** - * Contains all supported versions. - * All versions must be compatible with [semver](https://semver.org/spec/v2.0.0.html) format. - * If the version is not supported, we won't apply instrumentation patch (see `enable` method). - * If omitted, all versions of the module will be patched. - */ - supportedVersions?: string[]; } /** @@ -102,8 +94,6 @@ export interface InstrumentationModuleFile { /** Method to patch the instrumentation */ patch(moduleExports: unknown, moduleVersion?: string): unknown; - /** Method to patch the instrumentation */ - /** Method to unpatch the instrumentation */ unpatch(moduleExports?: unknown, moduleVersion?: string): void; } From 5050c3da6101130507d839766645afe08b793f94 Mon Sep 17 00:00:00 2001 From: Amir Blum Date: Fri, 10 May 2024 11:05:12 +0300 Subject: [PATCH 3/3] chore: CHANGELOG --- experimental/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 20e3fbfdab..53c4d368ba 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -17,6 +17,7 @@ All notable changes to experimental packages in this project will be documented * (internal) OTLPExporterBrowserBase: `RequestType` has been replaced by a `ResponseType` type-argument * (internal) OTLPExporterNodeBase: `ServiceRequest` has been replaced by a `ServiceResponse` type-argument * (internal) the `@opentelemetry/otlp-exporter-proto-base` package has been removed, and will from now on be deprecated in `npm` +* fix(instrumentation)!: remove unused supportedVersions from Instrumentation interface [#4694](https://github.com/open-telemetry/opentelemetry-js/pull/4694) @blumamir ### :rocket: (Enhancement)