Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote sampling #692

Closed
1 of 2 tasks
naseemkullah opened this issue Jan 14, 2020 · 9 comments
Closed
1 of 2 tasks

Remote sampling #692

naseemkullah opened this issue Jan 14, 2020 · 9 comments
Labels
signal:traces Issues and PRs related to general traces signal

Comments

@naseemkullah
Copy link
Member

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first

I want to have the sampling strategy configured at the Jaeger Collector as per https://www.jaegertracing.io/docs/1.16/sampling/#client-sampling-configuration ... this requires the client to have a "remote sampling" strategy. Is this possible today?

@naseemkullah
Copy link
Member Author

naseemkullah commented Jan 14, 2020

no, this is a unique feature of Jaeger clients.

@bforbis
Copy link

bforbis commented Oct 29, 2021

Will this be implemented? Support for jaeger remote sampling has been added to the opentelemetry specification

See OTEL_TRACES_SAMPLER =jaeger_remote in the specification

@dyladan
Copy link
Member

dyladan commented Oct 29, 2021

Interesting. The SDK spec doesn't list the jaeger remote sampler as a built-in sampler. Maybe this is a spec oversight? https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#built-in-samplers

@bforbis
Copy link

bforbis commented Oct 30, 2021

Can this issue be re-opened? I would like to have this functionality available.

@dyladan
Copy link
Member

dyladan commented Nov 1, 2021

Yes this issue can be reopened but it should likely be clarified in the spec if the jaeger remote sampler is a spec required component. If not, it would likely need to be implemented in the contrib repo.

@dyladan dyladan reopened this Nov 1, 2021
@MaheshGPai
Copy link

The spec is now updated and mentions Jaeger remote sampler.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#jaegerremotesampler

@MUI-Pop
Copy link

MUI-Pop commented Feb 13, 2023

Are there plans to implement jaeger remote sampling feature for JS ?

@shamil
Copy link

shamil commented Nov 21, 2023

Are there any plans to implement this?

@naseemkullah naseemkullah changed the title Remote sampling? Remote sampling Nov 28, 2023
@naseemkullah naseemkullah reopened this Nov 28, 2023
@pichlermarc
Copy link
Member

The spec has now been clarified that the remote sampler is supposed to be included with an SDK implementation.

I opened a new issue that should be a bit clearer what needs to be done to fully implement the feature, and where in the repo to put it, see #4534. I'm closing this issue in favor of the new one. I marked the new one as up-for-grabs in case anyone stumbling across this issue wants to work on it.

@pichlermarc pichlermarc closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
signal:traces Issues and PRs related to general traces signal
Projects
None yet
Development

No branches or pull requests

8 participants