Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting-started guide based on TracerRegistry #682

Closed
mayurkale22 opened this issue Jan 9, 2020 · 3 comments · Fixed by #709
Closed

Update getting-started guide based on TracerRegistry #682

mayurkale22 opened this issue Jan 9, 2020 · 3 comments · Fixed by #709
Assignees
@naseemkullah
Labels
document Documentation-related feature-request

Comments

@mayurkale22
Copy link
Member

The Named Tracers (TracerRegistry) PR has been merged now(#403), we need to update the documentation (examples and instructions) in getting-started guide.
@mayurkale22 mayurkale22 added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers document Documentation-related labels Jan 9, 2020
@mayurkale22 mayurkale22 mentioned this issue Jan 10, 2020
Merged
@naseemkullah
Copy link
Member

🙋‍♂

@naseemkullah
Copy link
Member

Can you provide a very brief tl;dr as to why this change from tracers to tracer registries has been made? It has to do with being able to name the tracers?

@dyladan
Copy link
Member

dyladan commented Jan 14, 2020

the most basic use case is disabling built-in instrumentation. Say mongodb builds opentelemetry directly into their library, but they mess it up; you can configure the tracer registry to return no-op tracers to the mongodb library.

@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jan 15, 2020
@naseemkullah naseemkullah mentioned this issue Jan 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naseemkullah naseemkullah

Labels
document Documentation-related feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update getting started to tracer registry naseemkullah/opentelemetry-js
3 participants
@dyladan @mayurkale22 @naseemkullah