We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem? Please describe. The following pattern is used in almost every plugin:
const span = tracer.startSpan(spanName, { parent: tracer.getCurrentSpan() || undefined, // ... });
This is because getCurrentSpan currently returns Span | null but parent is an optional Span (parent?: Span).
getCurrentSpan
Span | null
Span
parent?: Span
Describe the solution you'd like
Propose changing the signature of parent to parent?: Span | null.
parent
parent?: Span | null
Describe alternatives you've considered Continuing to use the parent: tracer.getCurrentSpan() || undefined, pattern
parent: tracer.getCurrentSpan() || undefined,
Additional context #525 (comment)
The text was updated successfully, but these errors were encountered:
pls assign me
Sorry, something went wrong.
Closing via #569
dyladan
No branches or pull requests
Is your feature request related to a problem? Please describe.
The following pattern is used in almost every plugin:
This is because
getCurrentSpan
currently returnsSpan | null
but parent is an optionalSpan
(parent?: Span
).Describe the solution you'd like
Propose changing the signature of
parent
toparent?: Span | null
.Describe alternatives you've considered
Continuing to use the
parent: tracer.getCurrentSpan() || undefined,
patternAdditional context
#525 (comment)
The text was updated successfully, but these errors were encountered: