Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented Breaking Change in Experimental v0.54.0 #5125

Closed
1 of 2 tasks
MustafaHaddara opened this issue Nov 7, 2024 · 1 comment · Fixed by #5169
Closed
1 of 2 tasks

Undocumented Breaking Change in Experimental v0.54.0 #5125

MustafaHaddara opened this issue Nov 7, 2024 · 1 comment · Fixed by #5169
Labels

Comments

@MustafaHaddara
Copy link
Contributor

PR #4971 rewrites exporter config logic and included this change, which changed the type of the headers config:

- headers?: Partial<Record<string, unknown>>;
+ headers?: Record<string, string>;

As a result, header values are now restricted to being string instead of previously being wide open and allowing any type.

What's the appropriate fix here? Just update the 0.54.0 section of the changelog? Ship a new version with no new code change but a new changelog entry?


  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first
@pichlermarc
Copy link
Member

Hi - thanks for reporting this. 🙂

What's the appropriate fix here? Just update the 0.54.0 section of the changelog? Ship a new version with no new code change but a new changelog entry?

Yep, we'd update the changelog entry for 0.54.0. When we merge the PR a maintainer needs to edit the GitHub release retroactively that it shows up there. We would not release a new version since the changelog is not included in the NPM package we released.

@pichlermarc pichlermarc changed the title Undocumented Breaking Change in Experimental v0.84.0 Undocumented Breaking Change in Experimental v0.54.0 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants