HTTP instrumentation metrics naming not matching OTel spec.

[evan361425]

What happened?

Steps to Reproduce

Code in https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-instrumentation-http/src/http.ts#L77-L95

Expected Result

Follow the HTTP metrics spec, http.server.duration naming should be http.server.request.duration and also the unit should be second not millisecond.

http.client.request.duration has the same issue.

Actual Result

Getting metric's name as http.server.duration not http.server.request.duration

Additional Details

Any customization should be great, or even making these properties protected.

Additionally, the attributes should also follow the recommended spec. Currently we have these attributes:

• HTTP_METHOD: should use http.request.method
• NET_PEER_NAME: should use server.address
• NET_PEER_PORT: should use server.port
• HTTP_STATUS_CODE: should use http.response.status_code
• HTTP_FLAVOR: deprecated

Some relevant issues:

• Ability to add custom metric attributes to http_client_duration and http_server_duration #4317

OpenTelemetry Setup Code

No response

package.json

No response

Relevant log output

No response

[JamieDanielson]

I believe this is a question about the semantic conventions needing to be updated, which is something that we are working on. The current tracking issue is #4572 , but note this is a high priority for us.

[JamieDanielson]

I'm going to close this as a duplicate since we are aware of it and tracking elsewhere.