-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[instrumentation] instrumentation base stabilization plan #4586
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
update: applied in #4847
|
one more breaking issue is making the instrumentation base
See #4668 currently blocked by open-telemetry/opentelemetry-js-contrib#2289 |
Description
The
@opentelemetry/instrumenation
package is the base package used for all instrumentations. To reduce the maintenance burden for instrumentation authors which currently need to deal with possible breaking changes as well as users that use the instrumentation registration mechanism, we should promote the@opentelemetry/instrumenation
package to stable.Currently the following issues prevent stabilization:
Logs API stability:
Types from the logs API are used in the public interface and may break type compatibility when using different versions of the instrumentation base in the same app. Therefore we need to hold off on marking the
@opentelemetry/instrumentation
package as stable until the Logs API is integrated into the@opentelemetry/api
package as a stable component OR we come up with a way to have experimental features in@opentelemetry/instrumentation
, where the stable interface does not depend on the non-stable@opentelemetry/api-logs
package.Option 1 (Logs API stabilization)
This will be addressed by
@opentelemetry/api/experimental
in Integrate @opentelemetry/api-logs package into @opentelemetry/api #4400, issues to stabilize the API)Option 2 (Experimental features in `@opentelemetry/instrumentation)
This will be addressed by
Instrumentation
,InstrumentationBase
#4839@types/shimmer
being part of the public API@types/shimmer
is currently part of the public API. We should avoid having a third-party dependency be part of the public API of this package.This will be addressed by:
shimmer
types from the public API #4837ESM instrumentation:
We currently offer an instrumentation customization hook for ESM in Node.js which uses
import-in-the-middle
. As of writing, the customization hooks concept is not yet stable in Node.js, but it is already available as a RC.We should therefore explicitly document one or multiple minimum supported Node.js versions / version ranges (especially with regards to Node.js LTS versions) based on the stability of the customization hook in that Node.js version. If no versions are stable yet declare the provided customization hook as fully experimental. Update versions as needed.
We should also document that direct usage of
import-in-the-middle/hook.mjs
may cease to work in the future and is purely experimental to prevent being locked into usingimport-in-the-middle
until the next major version, should we decide to move on from using that package for ESM instrumentation in the future and implement our own version of the customization hook at@opentelemetry/instrumentation/hook.mjs
We should also update documentation on how to set this customization hook when using the Node.js binary, be it via
--import
or otherwise, and explicitly declare all other ways that may be introduced in future Node.js versions as not directly supported (we may declare them as supported in a new minor version).This will be addressed by
Public API review:
We should replace any occurrence of
export *
with explicit exports and and review the API surface for any types and functions that we may be able to remove. We should also do a final review of the state of the@opentelemetry/instrumenation
package after the improvements mentioned above, and ensure that the package's API is up to our standards.This will be addressed by
The text was updated successfully, but these errors were encountered: