Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@opentelemetry/context-zone eradicates Promise.withResolvers #4354

Closed
dancrumb opened this issue Dec 11, 2023 · 2 comments · Fixed by #4469
Closed

@opentelemetry/context-zone eradicates Promise.withResolvers #4354

dancrumb opened this issue Dec 11, 2023 · 2 comments · Fixed by #4469
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc

Comments

@dancrumb
Copy link

What happened?

Steps to Reproduce

  • Open any web page that has @opentelemetry/context-zone as a dependency
  • Open a console
  • Run Promise.withResolvers()

Expected Result

Get {promise: Promise, resolve: f, reject: f}

Actual Result

Get a Promise.withResolvers is not a function

Additional Details

This is caused by a reliance on zone.js

OpenTelemetry Setup Code

No response

package.json

No response

Relevant log output

No response
@dancrumb dancrumb added bug Something isn't working triage labels Dec 11, 2023
@dancrumb dancrumb mentioned this issue Dec 11, 2023
Closed
@dyladan dyladan added priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc and removed triage labels Jan 3, 2024
@dyladan
Copy link
Member

dyladan commented Jan 3, 2024

Looks like this is fixed in zone.js-0.14.3. We are using a fairly outdated version of zone so it is probably a good idea for us to update. There is a PR to update it that is currently failing #4320

@dyladan
Copy link
Member

dyladan commented Jan 3, 2024

Depends on angular/angular#53630

@pichlermarc pichlermarc mentioned this issue Feb 9, 2024
Merged
3 tasks
@ajaffie ajaffie mentioned this issue Jul 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(context-zone*): support zone.js 0.13.x, 0.14.x dynatrace-oss-contrib/opentelemetry-js
2 participants
@dancrumb @dyladan