Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of "/" in Metrics Instrument Names #4141

Closed
aabmass opened this issue Sep 12, 2023 · 1 comment · Fixed by #4155
Closed

Allow use of "/" in Metrics Instrument Names #4141

aabmass opened this issue Sep 12, 2023 · 1 comment · Fixed by #4155
Assignees
Labels
pkg:sdk-metrics spec-feature This is a request to implement a new feature which is already specified by the OTel specification up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@aabmass
Copy link
Member

aabmass commented Sep 12, 2023

And update the validation

// ASCII string with a length no greater than 255 characters.
// NB: the first character counted separately from the rest.
const NAME_REGEXP = /^[a-z][a-z0-9_.-]{0,254}$/i;
export function isValidName(name: string): boolean {
return name.match(NAME_REGEXP) != null;
}

Then update spec compliance matrix https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md

@pichlermarc pichlermarc added up-for-grabs Good for taking. Extra help will be provided by maintainers spec-feature This is a request to implement a new feature which is already specified by the OTel specification pkg:sdk-metrics labels Sep 18, 2023
@aabmass
Copy link
Member Author

aabmass commented Sep 18, 2023

@pichlermarc can you assign to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:sdk-metrics spec-feature This is a request to implement a new feature which is already specified by the OTel specification up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants