Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk-logs] Logger includeTraceContext not defaulting to true #3816

Closed
hectorhdzg opened this issue May 17, 2023 · 0 comments · Fixed by #3817
Closed

[sdk-logs] Logger includeTraceContext not defaulting to true #3816

hectorhdzg opened this issue May 17, 2023 · 0 comments · Fixed by #3817
Assignees
@hectorhdzg
Labels
bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@hectorhdzg
Copy link
Member

What happened?

LoggerProvider getLogger method is sending includeTraceContext = undefined when logger options are not passed, causing default true value to be overridden. This is most common case so it is easy to miss trace context in logs.

OpenTelemetry Setup Code

No response

package.json

No response

Relevant log output

No response
@hectorhdzg hectorhdzg added bug Something isn't working triage labels May 17, 2023
@hectorhdzg hectorhdzg mentioned this issue May 17, 2023
Merged
4 tasks
@dyladan dyladan added priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect and removed triage labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorhdzg hectorhdzg

Labels
bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Milestone
No milestone
2 participants
@dyladan @hectorhdzg