Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider following OpenMetrics guidance on timestamps #3463

Closed
dashpole opened this issue Dec 2, 2022 · 3 comments · Fixed by #3961
Closed

Consider following OpenMetrics guidance on timestamps #3463

dashpole opened this issue Dec 2, 2022 · 3 comments · Fixed by #3961

Comments

@dashpole
Copy link
Contributor

dashpole commented Dec 2, 2022

By default, the prometheus exporter appends timestamps to metrics.

This goes against the current guidance from OpenMetrics about whether to expose timestamps.

We should consider not adding timestamps by default.

@dyladan dyladan added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Feb 6, 2023
@legendecas legendecas removed the stale label Feb 7, 2023
@JacksonWeber
Copy link
Contributor

@dyladan @legendecas Hi, I'd be happy to pick this up!

@pichlermarc
Copy link
Member

pichlermarc commented Jun 7, 2023

I think technically, our exporter uses the Prometheus text based exposition format as required by the spec in favor of OpenMetrics, but the same guidance is also present there.

@JacksonWeber thanks for picking this one up, it's yours 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants