Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting isMonotonic flag to exporters #3063

Closed
legendecas opened this issue Jun 28, 2022 · 1 comment · Fixed by #3079
Closed

Exporting isMonotonic flag to exporters #3063

legendecas opened this issue Jun 28, 2022 · 1 comment · Fixed by #3079
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@legendecas
Copy link
Member

legendecas commented Jun 28, 2022

I'm wondering if we should indicate isMonotonic in SingularMetricData. We have access to the data anyway, it is part of the proto, and it simplifies the transformation to OTLP.

Originally posted by @pichlermarc in #2990 (comment)

@pichlermarc you said you would like to work on this so I'm assigning this to you :).

@legendecas legendecas added this to the Metrics GA milestone Jun 28, 2022
@legendecas legendecas changed the title Exporting isMonotonic in OTLP SingularMetricData Exporting isMonotonic flag to exporters Jun 28, 2022
@dyladan dyladan added the enhancement New feature or request label Jun 28, 2022
@pichlermarc
Copy link
Member

This was a bit more work than I expected it to be. 😅

When I made that comment I forgot that there is only the SingularDataPoint interface that would have had to contain an optional isMonotonic field. Using that to distinguish between Sums and Gauges seemed very fragile, so to reduce the complexity in the exporter transformations, I had to split it up into a SumDataPoint (which contains isMonotonic) and a GaugeDataPoint (which does not contain it). Changes can be found in #3079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants